I can open a separate PR for lzc_rename and lzc_destroy while the rest are being discussed.
Regarding lzc_list_*, I need to think about that. The channel program iteration is great if everything is done within a program. But what if userland needs the list? Then the atomicity argument is immediately not applicable. Also, if the list of children is huge, can there be any problems with returning it userland? But I must admit that I haven't yet examined the channel program code well, so I think that I will have to do that before I can discuss further the list issue or the passing of props issue. Thank you for the review and suggestions! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/508#issuecomment-376862781 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/T3507ad6a4df1e9bb-M305b025e982d3f145d69bda2 Delivery options: https://openzfs.topicbox.com/groups
