ahrens commented on this pull request.
> @@ -34,7 +34,6 @@ */ #define tolower(C) (((C) >= 'A' && (C) <= 'Z') ? (C) - 'A' + 'a' : (C)) #define toupper(C) (((C) >= 'a' && (C) <= 'z') ? (C) - 'a' + 'A': (C)) -#define iscntrl(C) ((((C) >= 0) && ((C) <= 0x1f)) || ((C) == 0x7f)) It does seem simpler to just remove the `C >= 0` from the macro, and more consistent with the other `is*()` in this .c file being macros rather than functions. But I'm fine either way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/418#discussion_r178676626 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/Tf974af07ec408e5e-Me3a3e4bef56a5db6d13bebe0 Delivery options: https://openzfs.topicbox.com/groups
