stevenh requested changes on this pull request.
> @@ -159,7 +159,7 @@ vdev_dbgmsg_print_tree(vdev_t *vd, int indent)
}
zfs_dbgmsg("%*svdev %u: %s%s, guid: %llu, path: %s, %s", indent,
- "", vd->vdev_id, vd->vdev_ops->vdev_op_type,
+ "", (int)vd->vdev_id, vd->vdev_ops->vdev_op_type,
zdb uses ```%llu``` with ```u_longlong_t```
Should we do that for consistency, which is also less risky given the
definition of vdev_id?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/623#pullrequestreview-112307642
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/discussions/T2cb600ac138fbef6-M47af2196b7d8633b309b833c
Delivery options: https://openzfs.topicbox.com/groups
