sdimitro commented on this pull request.
> @@ -249,6 +249,31 @@ lzc_remap(const char *fsname)
return (error);
}
+int
+lzc_rename(const char *source, const char *target)
+{
+ zfs_cmd_t zc = { 0 };
+ int error;
+
Since this call (unfortunately) uses the old-style ioctl() call could you add
the following assertions?
```
ASSERT3S(g_refcount, >, 0);
VERIFY3S(g_fd, !=, -1);
```
`lzc_exists()` (same situation - old way) and `lzc_ioctl()` (the new-style;
common to most functions here)
both use these assertions to catch cases where consumers of the libzfs_core
forget to call the init function before subsequent calls to the library.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/660#pullrequestreview-132622470
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/T47f1cc3e459efd4d-Me965f6bd2195d5c9c9f4c826
Delivery options: https://openzfs.topicbox.com/groups
