ahrens commented on this pull request.
> @@ -1808,13 +1808,17 @@ zfs_prop_set_list(zfs_handle_t *zhp, nvlist_t *props)
ret = zfs_ioctl(hdl, ZFS_IOC_SET_PROP, &zc);
if (ret != 0) {
+ (void) zfs_standard_error(hdl, errno, errbuf);
Why do we need to call `zfs_standard_error()` here, even if
`zc_nvlist_dst_filled==TRUE`? Maybe I'm reading the code wrong, but it seems
like you'd get a repeated error message: one from this call, and then one from
zfs_setprop_error().
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/654#pullrequestreview-132625244
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/Tb4c6684d9add7dfe-M1e21eed0d6cc44e71965e310
Delivery options: https://openzfs.topicbox.com/groups
