Hi Igor, On Fri, Jun 29, 2018 at 8:55 AM Igor Kozhukhov <[email protected]> wrote: > right now, by step in zfstest - we do symbolic links to tempory directory and > update PATH to use it. > > but - we are using 'su user -c "<cmd line>" - where we use another PATH - it > is not the same as we defined. > > as example: zfs-tests/tests/functional/acl/cifs/cifs_attr_001_pos > > it use 'su' in some places where we use 'chmod' from another location - it is > not the same what we linked to temporary PATH. > > it is one example what we can’t trust to linked tools to temporary directory > with PATH. > > we have a lot of another scenarios where we can use another tools from > another locations and tests can produce incorrect resuts.
The su problem is definitely a bug; thanks for finding it. I would like to know what the other scenarios are. If you file an issue in the illumos tracker, I'll help you fix them. > based on these issues i’d like to start activity again to use full static > path to tools like CHMOD=/usr/bin/chmod - where we can be 100% sure we are > using what we want to use. > > current zfs tests define tools by symbolic links to temporary directory and > try to use it by providing PATH, but we can’t trust to this PATH and time to > time we are using tools from another location - it is not good and we can’t > trust to results. I respectfully disagree. The constrained path has other benefits which we have talked about before. I think the bug above can be solved without throwing out what's been done here. -- John Wren Kennedy http://www.delphix.com/ ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/T73c62864791e915c-Mb1767a775ba79bcde253de23 Delivery options: https://openzfs.topicbox.com/groups
