ahrens commented on this pull request.
> @@ -392,6 +392,22 @@ static int
dump_freeobjects(dmu_sendarg_t *dsp, uint64_t firstobj, uint64_t numobjs)
{
struct drr_freeobjects *drrfo = &(dsp->dsa_drr->drr_u.drr_freeobjects);
+ uint64_t maxobj = DNODES_PER_BLOCK *
+ (DMU_META_DNODE(dsp->dsa_os)->dn_maxblkid + 1);
+
+ /*
+ * Older versions of OpenZFS (since 7104) does not handle large
+ * FREEOBJECTS records correctly, leading to zfs recv never
completing.
Thanks for the update, @waikontse.
It looks like the indentation here is inconsistent. Each line should start
with `tab space asterisk`.
I think that in this context "since" means "more recent than", but I think you
mean "less recent than" / "older than"?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/685#pullrequestreview-160457752
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/Tcf25f566d2c2fe2d-M98bbe9212b512f4ebf262c0f
Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
