allanjude approved this pull request.
> @@ -92,124 +93,146 @@
* growth all other writers and readers must be excluded.
This comment should be updated to reflect that 128kb is no longer the maximum
block size
> - */
- if (new->r_type == RL_APPEND)
- new->r_off = zp->z_size;
-
- /*
- * If we need to grow the block size then grab the whole
- * file range. This is also done under z_range_lock to
- * avoid races.
- */
- end_size = MAX(zp->z_size, new->r_off + len);
- if (end_size > zp->z_blksz && (!ISP2(zp->z_blksz) ||
- zp->z_blksz < zp->z_zfsvfs->z_max_blksz)) {
- new->r_off = 0;
- new->r_len = UINT64_MAX;
- }
+ if (rl->rl_cb != NULL) {
It might be worth keeping a comment here about the fact that zvol's don't need
to deal with growing blocks etc, and that is the case where rl_cb will be NULL
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/680#pullrequestreview-160547752
------------------------------------------
openzfs: openzfs-developer
Permalink:
https://openzfs.topicbox.com/groups/developer/T0ada5cf1c6037d04-Ma66300b341eb84afc215b5fa
Delivery options: https://openzfs.topicbox.com/groups/developer/subscription
