On Tue, Oct 15, 2013 at 6:24 AM, Yuri Pankov <[email protected]> wrote: > On Mon, 14 Oct 2013 15:16:59 -0700, Christopher Siden wrote: >> >> http://cr.illumos.org/~webrev/csiden/illumos-zfs-tests/ >> >> Work by John Kennedy. This ports the rest of the ZFS test suite from >> STF (in a different repository on github) to the testrunner framework >> in illumos-gate. > > > Looks good, though I haven't looked through all added tests, only at the > infrastructure changes (thanks for fixing my typo). > > One question - are we really interested in *physical* CPUs in is_mp() > function? The tests where it's used don't give any hints why.
No, not really. I simply copied the usage that existed in several other places to a function without really scrutinizing it. I've filed a follow on bug to address this. -- John Wren Kennedy 275 Middlefield Road, Suite 50 Menlo Park, CA 94025 http://www.delphix.com/ _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
