On Sat, Nov 30, 2013 at 10:13 AM, Andriy Gapon <[email protected]> wrote: > [resending with CC fixed] > > Matt, > > as you most likely know, ZFS/FreeBSD already has ability to use TRIM command > with disks that support it. > As the command can be quite slow and it is a maintenance kind of command, it > makes sense to assign a very low priority to it. > > I've come up with the following change that introduces a new priority for the > TRIM zios: > http://people.freebsd.org/~avg/zfs-trim-priority.diff > To be honest, this change actually attempts to restore what we already had in > FreeBSD before I merged your write throttle & i/o scheduler performance work.
One small nit: + ZIO_PRIORITY_TRIM, /* slow auxiliary commands like TRIM */ Is this value meant only for TRIM? If so, the comment is wrong. If not, then the name should be changed (perhaps to ZIO_PRIORITY_AUX?) -- Eitan Adler _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
