Hello,

Thanks for replying!


> No, zct_zplprops is uninitialized in that case.  zct_props still points to
> the looked-up nvlist, which we do not free.
> 
> There is one critical difference between the code you quoted and what's in
> illumos:
> 
>   zfs_creat_t zct = { 0 };
> 
> By zeroing out zct, we ensure that zct_zplprops is NULL for the
> DMU_OST_ZVOL case.  nvlist_free(NULL) is a no-op.

3148            zct.zct_props = nvprops;

I was reading that as zct.zct_zplprops. My bad,

Thanks

Lund

-- 
Jorgen Lundman       | <[email protected]>
Unix Administrator   | +81 (0)3 -5456-2687 ext 1017 (work)
Shibuya-ku, Tokyo    | +81 (0)90-5578-8500          (cell)
Japan                | +81 (0)3 -3375-1767          (home)
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to