On Fri, Dec 06, 2013 at 06:32:07PM -0800, Max Grossman wrote:
> Hi Jeff!
>
> On Sun, Dec 1, 2013 at 12:02 PM, Josef 'Jeff' Sipek
> <[email protected]>wrote:
>
> > On Sun, Dec 01, 2013 at 10:55:16AM -0800, Christopher Siden wrote:
> > > http://code.delphix.com/illumos-4370/index.html
> > >
> > > Work by Max Grossman. See bug and updates to zpool-features(5) manpage
> > > in diff for details.
> >
> > Keep in mind that I'm not very familiar with the code...
....
> > Trivial nits related to coding style (I don't know what the prefered
> > openzfs
> > way is so I'm pointing out inconsistencies):
> >
> > zfeature.c: feature_get_enabled_txg() has useless {} in the if-statement
> >
> > spa_misc.c: the for-loop in spa_add() has useless {}
> >
> > dbuf.c: dbuf_write_ready() has useless {} near line 2491
> >
> > zhack.c: line 280 has useless {}
I'm happy. Looks good to me. (Do whatever you feel is appropriate with the
coding style nits.)
Jeff.
--
It used to be said [...] that AIX looks like one space alien discovered
Unix, and described it to another different space alien who then implemented
AIX. But their universal translators were broken and they'd had to gesture a
lot.
- Paul Tomblin
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
