Pardon the forward and top-post. We got this on the Illumos RTI queue. As an example to this developer, I'd like to forward this to the list for code review.
Thanks, Dan ----- Forwarded message from [email protected] ----- Date: Wed, 25 Dec 2013 05:52:34 +0100 (CET) From: [email protected] To: [email protected] Subject: [RTI] zfsctl_snapshot_inactive() vnode leak User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) Dear Illumos team, Please find a patch which would fix a vnode leak in zfsctl_snapshot_inactive() some rare cases, if I am right. Regards, Kojedzinszky Richard Euronet Magyarorszag Informatikai Zrt. ------------------------------------------- illumos-advocates Archives: https://www.listbox.com/member/archive/182187/=now RSS Feed: https://www.listbox.com/member/archive/rss/182187/22617126-adc5e6a3 Modify Your Subscription: https://www.listbox.com/member/?member_id=22617126&id_secret=22617126-6c0d80fe Powered by Listbox: http://www.listbox.com diff --git a/usr/src/uts/common/fs/zfs/zfs_ctldir.c b/usr/src/uts/common/fs/zfs/zfs_ctldir.c index 2f17496..cdfe55e 100644 --- a/usr/src/uts/common/fs/zfs/zfs_ctldir.c +++ b/usr/src/uts/common/fs/zfs/zfs_ctldir.c @@ -1214,6 +1214,7 @@ zfsctl_snapshot_inactive(vnode_t *vp, cred_t *cr, caller_context_t *ct) if (vp->v_count > 1) { mutex_exit(&sdp->sd_lock); + VN_RELE(dvp); return; } ASSERT(!vn_ismntpt(vp)); ----- End forwarded message ----- _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
