Looks good to me. --matt
On Thu, Jan 16, 2014 at 4:43 AM, Andriy Gapon <[email protected]> wrote: > > Without a patch at the end of this email zdb would (harmlessly) warn like > follows: > $ zdb -R pond 0:33c28ab000:200:b20 > ***Invalid flag: 2 > ***Invalid flag: 0 > .... > > How does the patch look to you? > Thanks! > > commit 942575354017b8bda8e36718628eaed5e7ec62c5 > Author: Andriy Gapon <[email protected]> > Date: Sun Oct 6 18:32:35 2013 +0300 > > zdb -R: do not treat numeric parameters to a flag as more flags > > diff --git a/cddl/contrib/opensolaris/cmd/zdb/zdb.c > b/cddl/contrib/opensolaris/cmd/zdb/zdb.c > index 32ece31..1870aca 100644 > --- a/cddl/contrib/opensolaris/cmd/zdb/zdb.c > +++ b/cddl/contrib/opensolaris/cmd/zdb/zdb.c > @@ -2960,6 +2960,7 @@ zdb_read_block(char *thing, spa_t *spa) > free(dup); > return; > } > + i += p - &flagstr[i + 1]; /* skip over the number > */ > } > } > > > -- > Andriy Gapon > > _______________________________________________ > developer mailing list > [email protected] > http://lists.open-zfs.org/mailman/listinfo/developer > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
