Yes, I tested it.
I will prepare and send RTI.

Thanks.

On 02/05/2014 12:59 AM, Matthew Ahrens wrote:
Gosh, that is embarrassing.  Yes, it should be VERIFY0.

If you have tested the fix then please feel free to submit an RTI to integrate it into illumos (and count me as a code reviewer). Or I can fix it if you'd prefer.

--matt


On Tue, Feb 4, 2014 at 11:58 AM, Alexander Stetsenko <[email protected] <mailto:[email protected]>> wrote:

    Hi folks.

    I've found that get_clones_stat function behaves differently for
    DEBUG and non-DEBUG kernels.
    As result non-DEBUG kernel never makes up clones list.
    The reason is zap_count function being called inside ASSERT0,
    VERIFY0 should be used instead.

    Matt, could you comment, pls? (git blames you).

    If you use only "zfs" utility to get zfs properties you will
    probably never notice this issue, because it uses workaround for it.

    The attached patch solves the issue.


    Thanks.



_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to