-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi,
My understanding is that the metaslabs are only used when we need to allocate some space, thus have nothing to do with read-only pools, right? Daniel hit a panic today and asked for my help. Looking at the traceback, current codepath would go spa_load -> vdev_load -> vdev_load -> vdev_metaslab_init -> metaslab_init, where it asserts space_map_open() always succeeds. For read-write pools this is sensible but it is (in my opinion) not needed for read-only imports. Will it be reasonable to add a flag that is passed to vdev_load so it skips loading metaslab, or did I missed something obvious? Cheers, - -- Xin LI <[email protected]> https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBCgAGBQJTTbsGAAoJEJW2GBstM+nspkUQAKVmhojlnz6Ji3vxjXaoK0Bx mtTXaDoGcQvCu71DWTgjAIpJqhb1lX9gtZP958M7oRgCbP42TYW2BQJuXniNRloA NfNjr8BSN6+uQEjXTbqYuDTKGn6yvN6R4776TcplvmFjA9iUXBAvt0XudKz/zd+c TAcmIh+KnWNKv1Zj0OQHlm+sZAQHH5qirCF6b0sqsD9vuC+t+gsB8f022xIkWnXd WGmYIfZOHDQHIg3/YA1E6pMAAwvJM8YgRdGw20AoCIjl+ctEGFxomLp7L7/GYeEI CxGeDkMTaRYnz1BzM4ydYRr1eS3FilJbMW6Y1XcA2ljvzdpgcv8qtkyadKFUMSwq 5AMJoYeQwhlHCvzcr66A4VpL/9dGglcey4KkGYtbKdTUYObO/GiFLo1wmDeibbaV IM9hecF4kHzdHrHwGn3sfvmDo3F00+9cQ3mMGwVW315VnV9LURAscG+AkmdcDa0M f+zLU1+XZVK8w2qXr1s+hso/klRM98/SqlQfTH5JZrLJEc41nhGPhmW20JcNXAl8 MLIn3heAaGqfcIS0qpTxO5FM6+fElR08519X3TUgy7GaNwMeV7pjEi990qRc9GM/ v6ria9yc8m7Q1RVHcG7yR3R3Dzg8x/JXRKa0xa4oMsAcm8xuuSkrpMUHkGLl1BL+ DmqbE3y9TKwrbCVj20dr =O0gQ -----END PGP SIGNATURE----- _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
