----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/110/#review273 -----------------------------------------------------------
I'm a bit uncomfortable with the level of bug reporting and fix analysis here. The changes would seem sufficient to preventing panic in this case of import failure, but what's not clear is how we expect this to be handled thereafter, given that we don't handle it in these code paths, such that we know that we are doing the right thing, minimally for the range of errors that metaslab_init() can currently be passed by space_map_open(). - Bayard Bell On Oct. 6, 2014, 2:02 p.m., Prakash Surya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/110/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 2:02 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5213 > https://www.illumos.org/projects/illumos-gate//issues/5213 > > > Repository: illumos-gate > > > Description > ------- > > 5213 panic in metaslab_init due to space_map_open returning ENXIO > Reviewed by: Matthew Ahrens <[email protected]> > Reviewed by: George Wilson <[email protected]> > > Original author: Prakash Surya > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/vdev.c 7571b21a5f8cd5c0a1d6406556bcc22fcaceb814 > usr/src/uts/common/fs/zfs/sys/metaslab.h > 7fd47c08c9df5a7a3f6f24c6a4deda84502d0b19 > usr/src/uts/common/fs/zfs/metaslab.c > a33ec7f628108f5c3d2206583b060e2d580a7dca > > Diff: https://reviews.csiden.org/r/110/diff/ > > > Testing > ------- > > > Thanks, > > Prakash Surya > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
