----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/126/#review314 -----------------------------------------------------------
Ship it! Code looks good. Needs sanity checking with ztest & zfs test suite. - Matthew Ahrens On Nov. 11, 2014, 6:52 p.m., Justin Gibbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/126/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 6:52 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5310 > https://www.illumos.org/projects/illumos-gate//issues/5310 > > > Repository: illumos-gate > > > Description > ------- > > Remove always true tests for ds->ds_phys' presence. > Clean up assertions in dsl_dataset_disown. > Remove unreachable code in dsl_dataset_disown(). > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dsl_prop.c > 7e62635176dfb1f5f640369ba7c72273ecaa85cc > usr/src/uts/common/fs/zfs/dsl_dataset.c > e7ed7509020851f991999f21138b1b156d8d2948 > > Diff: https://reviews.csiden.org/r/126/diff/ > > > Testing > ------- > > > Thanks, > > Justin Gibbs > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
