-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/129/
-----------------------------------------------------------
(Updated Nov. 11, 2014, 11:46 p.m.)
Review request for OpenZFS Developer Mailing List.
Bugs: 5314
https://www.illumos.org/projects/illumos-gate//issues/5314
Repository: illumos-gate
Description
-------
Author: Justin T. Gibbs <[email protected]>
Date: Tue Nov 11 14:54:48 2014 -0800
Remove "dbuf phys" db->db_data pointer aliases.
Use function accessors that cast db->db_data to the appropriate
"phys" type, removing the need for clients of the dmu buf user
API is keep properly typed pointer aliases to db->db_data in order
to conveniently access their data.
cmd/mdb/common/modules/zfs/Makefile.zfs:
cmd/mdb/intel/amd64/libzpool/Makefile:
cmd/mdb/intel/amd64/zfs/Makefile:
cmd/mdb/intel/ia32/libzpool/Makefile:
cmd/mdb/intel/ia32/zfs/Makefile:
cmd/mdb/sparc/v7/libzpool/Makefile:
cmd/mdb/sparc/v9/libzpool/Makefile:
cmd/mdb/sparc/v9/zfs/Makefile:
cmd/zdb/Makefile.com:
Silence E_STATIC_UNUSED lint warnings.
cmd/mdb/common/modules/zfs/zfs.c:
uts/common/fs/zfs/zap_leaf.c:
In zap_leaf() and zap_leaf_byteswap, now that the pointer alias
field l_phys has been removed, use the db_data field in an on
stack dmu_buf_t to point to the leaf's phys data.
uts/common/fs/zfs/dbuf.c:
Remove the db_user_data_ptr_ptr field from dbuf and all logic
to maintain it.
uts/common/fs/zfs/dbuf.c:
uts/common/fs/zfs/dnode.c:
uts/common/fs/zfs/sys/dbuf.h:
uts/common/fs/zfs/sys/dmu.h:
uts/common/fs/zfs/dsl_dataset.c:
uts/common/fs/zfs/dsl_dir.c:
uts/common/fs/zfs/sa.c:
uts/common/fs/zfs/zap.c:
uts/common/fs/zfs/zap_micro.c:
Modify the DMU buf user API to remove the ability to specify
a db_data aliasing pointer (db_user_data_ptr_ptr).
cmd/zdb/zdb.c:
uts/common/fs/zfs/dmu_diff.c:
uts/common/fs/zfs/dmu_objset.c:
uts/common/fs/zfs/dmu_send.c:
uts/common/fs/zfs/dmu_traverse.c:
uts/common/fs/zfs/dmu_tx.c:
uts/common/fs/zfs/dsl_bookmark.c:
uts/common/fs/zfs/dsl_dataset.c:
uts/common/fs/zfs/dsl_deadlist.c:
uts/common/fs/zfs/dsl_deleg.c:
uts/common/fs/zfs/dsl_destroy.c:
uts/common/fs/zfs/dsl_dir.c:
uts/common/fs/zfs/dsl_pool.c:
uts/common/fs/zfs/dsl_prop.c:
uts/common/fs/zfs/dsl_scan.c:
uts/common/fs/zfs/dsl_synctask.c:
uts/common/fs/zfs/dsl_userhold.c:
uts/common/fs/zfs/sa.c:
uts/common/fs/zfs/spa.c:
uts/common/fs/zfs/spa_history.c:
uts/common/fs/zfs/zap.c:
uts/common/fs/zfs/zap_leaf.c:
uts/common/fs/zfs/zap_micro.c:
uts/common/fs/zfs/zfs_ioctl.c:
uts/common/fs/zfs/sys/dsl_dataset.h:
uts/common/fs/zfs/sys/dsl_dir.h:
uts/common/fs/zfs/sys/zap_impl.h:
uts/common/fs/zfs/sys/zap_leaf.h:
Create and use the new "phys data" accessor functions
dsl_dir_phys(), dsl_dataset_phys(), zap_m_phys(),
zap_f_phys(), and zap_leaf_phys().
uts/common/fs/zfs/sys/dsl_dataset.h:
uts/common/fs/zfs/sys/dsl_dir.h:
uts/common/fs/zfs/sys/zap_impl.h:
uts/common/fs/zfs/sys/zap_leaf.h:
Remove now unused "phys pointer" aliases to db->db_data
from clients of the DMU buf user API.
Diffs
-----
usr/src/uts/common/fs/zfs/sys/zap_leaf.h
f6947a72d70e947c4aece66425cb16dd743ecee8
usr/src/uts/common/fs/zfs/sys/dsl_dir.h
a9c4f67515a9539b3169f0d35884eee6a1f9829b
usr/src/uts/common/fs/zfs/sys/dmu.h 93165a95951d534fdf7d7cd29dc31236c192602c
usr/src/uts/common/fs/zfs/sys/dbuf.h 8ca8753e5e6d55b13c6d9dde37b3c288feb35066
usr/src/uts/common/fs/zfs/zfs_ioctl.c
a05e7b2a29b31de19cce7791a442cb1803e9f1e1
usr/src/uts/common/fs/zfs/zap_leaf.c 78f05d7a7e37eaf2df7961fb13a608e1c5ab2f2f
usr/src/uts/common/fs/zfs/zap.c fb79e5a257136ba8d4f429684fd92226d8706420
usr/src/uts/common/fs/zfs/spa_history.c
ce64f70b28c39a485abe1848e9f988611bffce51
usr/src/uts/common/fs/zfs/spa.c 634967c46f1b148912b7c53e2737d36076c8686f
usr/src/uts/common/fs/zfs/sa.c 8b3963aed9f57332de5b2b551492bae704f1a1ce
usr/src/uts/common/fs/zfs/dsl_userhold.c
b6878d7ecc440cb3adcc5593b579c50f50074c94
usr/src/uts/common/fs/zfs/dsl_scan.c 2392b7f336952a2cc9dbf4983f8f83c5fc53d9a8
usr/src/uts/common/fs/zfs/dsl_prop.c 5907ea281b0eee2620e1d5a2e2a747c2b2d7f341
usr/src/uts/common/fs/zfs/dsl_pool.c 1d246b8e688d37b4925d9c22e23bc001e9faa055
usr/src/uts/common/fs/zfs/dsl_dir.c 415bd91e9041179c3c196831b6ec81ee3bb00cdc
usr/src/uts/common/fs/zfs/dsl_destroy.c
1237641583a1bf32bd76b8b71cbdd497c9963de9
usr/src/uts/common/fs/zfs/dsl_deleg.c
9c6f38a6bdeaae0281e80ab2cb56b323a89d5b0b
usr/src/uts/common/fs/zfs/dsl_dataset.c
5ac0050aef420b51565d24d4daa62778a82e76a3
usr/src/uts/common/fs/zfs/dsl_bookmark.c
21784630da6b95c5131c2f94fa28fa419986ac64
usr/src/uts/common/fs/zfs/dnode.c 9c70c2bfb1b09e8284e59b7b6d6977b0704a800d
usr/src/uts/common/fs/zfs/dmu_tx.c d249762e5a2c4d26ec0bfeb87e8cb976bc3912a3
usr/src/uts/common/fs/zfs/dmu_traverse.c
5836549d200ac844e7dd4daca8f7843ef243959c
usr/src/uts/common/fs/zfs/dmu_objset.c
e7aeed17fb9d18eff85f1cdee1795d42fd500e41
usr/src/uts/common/fs/zfs/dmu_diff.c 30fabbb07957f9566d620e2a1bd8d64430fdb1d2
usr/src/cmd/zdb/zdb.c 36c4a8515b367cc198b8874f0d5ace16da8409b3
usr/src/cmd/zdb/Makefile.com b538d38335e0fc1e5f16bf0ca994b01423185d58
usr/src/cmd/mdb/sparc/v9/zfs/Makefile
aa63a724fb5b51bb87f41568b34cfcdb8c0a552e
usr/src/cmd/mdb/sparc/v7/libzpool/Makefile
54a2d6f42ccebd5044070444b250ad819e794142
usr/src/cmd/mdb/intel/ia32/zfs/Makefile
8220aa4947ae5dec930736e07ddc0574773e3590
usr/src/cmd/mdb/intel/ia32/libzpool/Makefile
bb2758e83bf8dcd4fb60c968fda1b8fcbc0ba4bd
usr/src/cmd/mdb/intel/amd64/libzpool/Makefile
fa059da58bb6fbb7a5a763fe098f887706e75be8
usr/src/cmd/mdb/common/modules/zfs/zfs.c
763e560bac21e50a3d30e013a3f10ffe1c8e41ec
usr/src/cmd/mdb/common/modules/zfs/Makefile.zfs PRE-CREATION
usr/src/uts/common/fs/zfs/zap_micro.c
59a9f970448a12b1e7de48f2b87c6eef4cc577eb
usr/src/uts/common/fs/zfs/sys/zap_impl.h
8b4a8b2b56ed5f1cf8fe581039f0e477590dee7c
usr/src/uts/common/fs/zfs/sys/dsl_dataset.h
ff90f8b439ccf7a137adcf10ba2c018bd9ae30aa
usr/src/uts/common/fs/zfs/dsl_synctask.c
8e09347678ddbdaf13f925a149122dd4209624d7
usr/src/uts/common/fs/zfs/dsl_deadlist.c
8c8e3746eecb59fb2a2af5aea221e84b998d6085
usr/src/uts/common/fs/zfs/dmu_send.c 2c08e7075f66ab6b69bc4b8a7560a837915a6e12
usr/src/uts/common/fs/zfs/dbuf.c a5816e12ccf0c4d56d8f0de0a571aa7576e427bf
usr/src/cmd/ztest/Makefile.com 360ebb2bde974e1e135f0dbe1160c4f6bda8be41
usr/src/cmd/mdb/sparc/v9/libzpool/Makefile
d7be9ab133b0abf77da747b47e33100e8979b165
usr/src/cmd/mdb/intel/amd64/zfs/Makefile
97a4a859c97f46f5de42888564d7a6c5ff803f2a
Diff: https://reviews.csiden.org/r/129/diff/
Testing
-------
Thanks,
Justin Gibbs
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
