----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/128/#review319 -----------------------------------------------------------
usr/src/uts/common/fs/zfs/vdev_queue.c <https://reviews.csiden.org/r/128/#comment280> Whats the excepted style for this type a construct? I ask as personally I would write this as: if (t == ZIO_TYPE_READ) return (&vq->vq_read_offset_tree); return (&vq->vq_write_offset_tree); - Steven Hartland On Nov. 11, 2014, 9:46 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/128/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2014, 9:46 p.m.) > > > Review request for OpenZFS Developer Mailing List, Justin Gibbs and George > Wilson. > > > Bugs: 5313 > https://www.illumos.org/projects/illumos-gate//issues/5313 > > > Repository: illumos-gate > > > Description > ------- > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/vdev_impl.h: > Add two offset/lba based AVL trees to the vdev queue > object. > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zio.h: > Add a second AVL node within each ZIO so that vdev_queue.c > can sort ZIOs by both type and priority. > > sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_queue.c: > Combine reads and writes, irrespecitve of their priorities > into unified, offset sorted, trees. Selection of the > ZIO to issue is unchanged, but aggregation now uses the > unified tree of the appropriate type so that aggregation > across priority classes is possible. > > Original author: Justin T. Gibbs <[email protected]> > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/vdev_queue.c > f47c4cd1e26dfa635dcf28e4ea3cd0cc8de4e3d1 > usr/src/uts/common/fs/zfs/sys/zio.h > f6cf259bf71a741cfee8e290be93c0600c5c9240 > usr/src/uts/common/fs/zfs/sys/vdev_impl.h > 6d9bcb17d00fd70d1585b9c2218086ca2239aab6 > > Diff: https://reviews.csiden.org/r/128/diff/ > > > Testing > ------- > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
