----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/127/#review337 -----------------------------------------------------------
Ship it! Ship It! - Will Andrews On Nov. 15, 2014, 4:38 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/127/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2014, 4:38 p.m.) > > > Review request for OpenZFS Developer Mailing List, Justin Gibbs and Matthew > Ahrens. > > > Bugs: 5311 > https://www.illumos.org/projects/illumos-gate//issues/5311 > > > Repository: illumos-gate > > > Description > ------- > > If a dnode has a spill block and there is an error while accessing > a data block then traverse_dnode() loses information about that error > and returns a status of visiting the spill block. > This issue is discovered by Spectra Logic. > > Original author: Justin T. Gibbs <[email protected]> > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/dmu_traverse.c > 5836549d200ac844e7dd4daca8f7843ef243959c > > Diff: https://reviews.csiden.org/r/127/diff/ > > > Testing > ------- > > zfs test suite > ztest > > for help with preparing your RTI email, see below. Re-run the git commands > with your final commit message (with reviewers listed) and author (Justin) > > (internal link: http://jenkins/job/zfs-precommit/1132/) > > ``` > ##### Begin Illumos advocates mail ##### > <<< INSERT YOUR PUBLICLY VISIBLE REVIEWBOARD URL HERE >>> > > Chris will do the push once someone approves it. > > $ git whatchanged HEAD^.. > commit affc3ac0626b10d1a5140f657bd95f7ddecb6a3f > Author: Matthew Ahrens <[email protected]> > Date: Fri Nov 14 21:44:59 2014 -0800 > > 5311 traverse_dnode may report success when it should not > > :100644 100644 5836549... 5523f62... M > usr/src/uts/common/fs/zfs/dmu_traverse.c > > $ git pbchk -b HEAD^ > > > ==== Nightly distributed build started: Sat Nov 15 02:22:22 PST 2014 ==== > ==== Nightly distributed build completed: Sat Nov 15 05:13:10 PST 2014 ==== > > ==== Total build time ==== > > real 2:50:48 > > ==== Build environment ==== > > /usr/bin/uname > SunOS totality 5.11 os-build-build-2161 i86pc i386 i86pc > > /usr/bin/dmake > dmake: Sun Distributed Make 7.9 SunOS_i386 2009/06/03 > number of concurrent jobs = 6 > > 32-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > 64-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > /usr/java/bin/javac > java full version "1.6.0_26-b03" > > /usr/ccs/bin/as > as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009 > > /usr/ccs/bin/ld > ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1749 > (illumos) > > Build project: group.staff > Build taskid: 321 > > ==== Nightly argument issues ==== > > > ==== Build version ==== > > os-build-build-2578 > > ==== Make clobber ERRORS ==== > > > ==== Make tools clobber ERRORS ==== > > > ==== Tools build errors ==== > > > ==== Build errors (non-DEBUG) ==== > > > ==== Build warnings (non-DEBUG) ==== > > > ==== Elapsed build time (non-DEBUG) ==== > > real 1:09:25.1 > user 1:40:19.6 > sys 29:40.1 > > ==== Build noise differences (non-DEBUG) ==== > > > ==== package build errors (non-DEBUG) ==== > > > ==== Build errors (DEBUG) ==== > > > ==== Build warnings (DEBUG) ==== > > > ==== Elapsed build time (DEBUG) ==== > > real 44:58.6 > user 1:28:09.4 > sys 21:19.9 > > ==== Build noise differences (DEBUG) ==== > > > ==== package build errors (DEBUG) ==== > > > ==== Validating manifests against proto area ==== > > > ==== Check ELF runtime attributes ==== > > > ==== Diff ELF runtime attributes (since last build) ==== > > > ==== 'dmake lint' of src ERRORS ==== > > > ==== Elapsed time of 'dmake lint' of src ==== > > real 35:20.5 > user 1:10:39.8 > sys 12:36.2 > > ==== lint warnings src ==== > > > ==== lint noise differences src ==== > > > ==== cstyle/hdrchk errors ==== > > > ==== Find core files ==== > > > ==== Check lists of files ==== > > > ==== Impact on file permissions ==== > > > ==== Running POST_NIGHTLY command: > /data/jenkins/zfs-precommit/build-1132-2e03/jenkins_helper.sh ==== > > ##### End Illumos advocates mail ##### > ``` > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
