----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/64/#review340 -----------------------------------------------------------
usr/src/lib/libzfs/common/sys/zfs_context.h <https://reviews.csiden.org/r/64/#comment290> Since you wrote this entire file from scratch (I assume, given that you removed the other copyrights), you are encouraged (but not required) to use the new, "version 1.0 only" form of the CDDL notice. See usr/src/uts/common/fs/zfs/blkptr.c for an example. - Matthew Ahrens On Nov. 19, 2014, 7:39 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/64/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 7:39 p.m.) > > > Review request for OpenZFS Developer Mailing List, Justin Gibbs and Matthew > Ahrens. > > > Bugs: 5312 > https://www.illumos.org/projects/illumos-gate//issues/5312 > > > Repository: illumos-gate > > > Description > ------- > > 5312 Decouple libzfs from the kernel's zfs_context.h. > > Original author: Justin T. Gibbs > > > Diffs > ----- > > usr/src/lib/libzfs/common/sys/zfs_context.h PRE-CREATION > > Diff: https://reviews.csiden.org/r/64/diff/ > > > Testing > ------- > > zfs test suite > ztest > > (internal link: http://jenkins/job/zfs-precommit/1131/) > > for help with preparing your RTI email, see below. Re-run the git commands > with your final commit message (with reviewers listed) and author (Justin) > > ``` > ##### Begin Illumos advocates mail ##### > <<< INSERT YOUR PUBLICLY VISIBLE REVIEWBOARD URL HERE >>> > > Chris will do the push once someone approves it. > > $ git whatchanged HEAD^.. > commit 3801dd6a5b824c920d7046855c40b461418ae07b > Author: Matthew Ahrens <[email protected]> > Date: Tue Nov 11 11:27:07 2014 -0800 > > 5312 libzfs should be decoupled from kernel's zfs_context.h > > :000000 100644 0000000... 6305bf5... A > usr/src/lib/libzfs/common/sys/zfs_context.h > > $ git pbchk -b HEAD^ > Copyrights: > usr/src/lib/libzfs/common/sys/zfs_context.h: no copyright claim for current > year found > > > ==== Nightly distributed build started: Sat Nov 15 00:15:48 PST 2014 ==== > ==== Nightly distributed build completed: Sat Nov 15 04:18:03 PST 2014 ==== > > ==== Total build time ==== > > real 4:02:14 > > ==== Build environment ==== > > /usr/bin/uname > SunOS totality 5.11 os-build-build-2161 i86pc i386 i86pc > > /usr/bin/dmake > dmake: Sun Distributed Make 7.9 SunOS_i386 2009/06/03 > number of concurrent jobs = 6 > > 32-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > 64-bit compiler > /opt/onbld/bin/i386/cw -_gcc > cw version 1.29 (SHADOW MODE DISABLED) > primary: /opt/gcc/4.4.4/bin/gcc > gcc (Illumos gcc-4.4.4-il-3) 4.4.4 > > /usr/java/bin/javac > java full version "1.6.0_26-b03" > > /usr/ccs/bin/as > as: Sun Compiler Common 12 SunOS_i386 snv_121 08/03/2009 > > /usr/ccs/bin/ld > ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1749 > (illumos) > > Build project: group.staff > Build taskid: 318 > > ==== Nightly argument issues ==== > > > ==== Build version ==== > > os-build-build-2576 > > ==== Make clobber ERRORS ==== > > > ==== Make tools clobber ERRORS ==== > > > ==== Tools build errors ==== > > > ==== Build errors (non-DEBUG) ==== > > > ==== Build warnings (non-DEBUG) ==== > > > ==== Elapsed build time (non-DEBUG) ==== > > real 1:17:10.1 > user 2:01:11.7 > sys 37:50.1 > > ==== Build noise differences (non-DEBUG) ==== > > > ==== package build errors (non-DEBUG) ==== > > > ==== Build errors (DEBUG) ==== > > > ==== Build warnings (DEBUG) ==== > > > ==== Elapsed build time (DEBUG) ==== > > real 1:07:12.0 > user 1:33:01.2 > sys 23:12.0 > > ==== Build noise differences (DEBUG) ==== > > > ==== package build errors (DEBUG) ==== > > > ==== Validating manifests against proto area ==== > > > ==== Check ELF runtime attributes ==== > > > ==== Diff ELF runtime attributes (since last build) ==== > > > ==== 'dmake lint' of src ERRORS ==== > > > ==== Elapsed time of 'dmake lint' of src ==== > > real 55:14.0 > user 1:13:52.9 > sys 12:53.2 > > ==== lint warnings src ==== > > > ==== lint noise differences src ==== > > > ==== cstyle/hdrchk errors ==== > > > ==== Find core files ==== > > > ==== Check lists of files ==== > > > ==== Impact on file permissions ==== > > > ==== Running POST_NIGHTLY command: > /data/jenkins/zfs-precommit/build-1131-2e03/jenkins_helper.sh ==== > > ##### End Illumos advocates mail ##### > ``` > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
