-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/134/
-----------------------------------------------------------
(Updated Nov. 22, 2014, 11:21 p.m.)
Review request for OpenZFS Developer Mailing List, Dan McDonald and Rich Lowe.
Changes
-------
review feedback
Bugs: 5349
https://www.illumos.org/projects/illumos-gate//issues/5349
Repository: illumos-gate
Description
-------
5349 verify that block pointer is plausible before reading
Reviewed by: Christopher Siden <[email protected]>
Reviewed by: Alex Reece <[email protected]>
Reviewed by: George Wilson <[email protected]>
We want to verify that the block pointer is structurally valid, before
attempting to read it in. It can only be invalid in the case of a ZFS bug, but
this change will help identify such bugs in a more transparent way, by
panic'ing with a relevant message, rather than indexing off the end of an array
or something.
Original author: Matthew Ahrens
Diffs (updated)
-----
usr/src/uts/common/fs/zfs/zio.c 7cb6953845eb6cbd6346c22cd3a0cf9a311e463c
usr/src/uts/common/fs/zfs/sys/spa.h e4731ae5a7391c48be34d23e77478a47ca86c30f
Diff: https://reviews.csiden.org/r/134/diff/
Testing
-------
ztest
zfs test suite
(internal link: http://jenkins/job/zfs-precommit/1148/)
Thanks,
Matthew Ahrens
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
