----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/145/#review419 -----------------------------------------------------------
usr/src/uts/common/fs/zfs/arc.c <https://reviews.csiden.org/r/145/#comment354> Thanks for documenting this! I've seen b_thawed in the past, and it confused me. I've been told that it's for debugging of some sort. Would it make sense to instead of relying on kmem's stack saving debug feature to just make an array of pc_t and call getpcstack directly - at the expense of making l1arc_buf_hdr larger on debug kernels? - Josef 'Jeff' Sipek On Dec. 17, 2014, 10:31 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/145/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 10:31 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5408 > https://www.illumos.org/projects/illumos-gate//issues/5408 > > > Repository: illumos-gate > > > Description > ------- > > 5408 managing ZFS cache devices requires lots of RAM > Reviewed by: Matthew Ahrens <[email protected]> > Reviewed by: George Wilson <[email protected]> > Reviewed by: Christopher Siden <[email protected]> > > Original author: Chris Williamson > > Note: depends on https://reviews.csiden.org/r/140/; will push after that. > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/sys/arc.h > 83ea6f7fbc7ccdf3c5fa9e405add4a204d38c4af > usr/src/uts/common/fs/zfs/arc.c 435096becc75fa0a519424fbe8bd69e4cd2dc50c > usr/src/cmd/ztest/ztest.c a5f960080465e00d364230580a3b10405052431e > usr/src/cmd/mdb/common/modules/zfs/zfs.c > c8b296847d017e6a985b5ccb8a2da40b2f50a629 > > Diff: https://reviews.csiden.org/r/145/diff/ > > > Testing > ------- > > ztest > zfs-test > internal use on NFS servers with l2arc devices > > internal link: http://jenkins/job/zfs-precommit/1378/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
