> On Dec. 17, 2014, 4:31 p.m., Prakash Surya wrote:
> > This is failing a number of tests in the zfs test suite that aren't
> >
> > known to be problematic (which hints to an issue with the patch):
> >
> >
> >
> > FAIL cli_root/zfs_mount/zfs_mount_all_001_pos [no bug found]
> >
> > FAIL rsend/rsend_009_pos [no bug found]
> >
> > FAIL cli_root/zfs_create/zfs_create_008_neg [no bug found]
> >
> > FAIL link_count/link_count_001 [no bug found]
> >
> > FAIL rootpool/rootpool_002_neg [no bug found]
> >
> > FAIL cli_root/zfs_mount/zfs_mount_009_neg [no bug found]
> >
> > FAIL zvol/zvol_swap/setup [no bug found]
> >
> > FAIL mmap/mmap_write_001_pos [no bug found]
> >
> > FAIL cli_root/zpool_create/zpool_create_023_neg [no bug found]
> >
> >
> >
> > We'll need get these tests to pass before we can land this.
> >
> >
> >
> > Xin, do you need help digging in to these failures? Or can you debug and
> >
> > fix these on your own? The tests themselves are in the illumos tree
> >
> > under "usr/src/test/zfs-tests/tests", but if you don't have an illumos
> >
> > system to run them on, it might be difficult for you to debug.
> >
> > In the meantime, I've kicked off another test run just to make
> > sure the failures weren't due to some internal infrastructure issue:
> >
> > http://jenkins/job/zfs-precommit/1406/
>
> Xin LI wrote:
> Hrm this is quite weird as most of the tests does not relate to the
> change. Do they succeed without the change?
Sorry for the delay. Upon looking furthur, these aren't specific to this patch.
They're failing on illumos' HEAD too, :(. So, in light of that, and the other
reviews, looks good to me; please just fix this one C-style issue:
C style:
usr/src/uts/common/fs/zfs/dsl_dataset.c: 406: line > 80 characters
- Prakash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.csiden.org/r/143/#review412
-----------------------------------------------------------
On Dec. 5, 2014, 5:46 p.m., Xin LI wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.csiden.org/r/143/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 5:46 p.m.)
>
>
> Review request for OpenZFS Developer Mailing List, Christopher Siden and
> Matthew Ahrens.
>
>
> Bugs: 5393
> https://www.illumos.org/projects/illumos-gate//issues/5393
>
>
> Repository: illumos-gate
>
>
> Description
> -------
>
> The large block code introduced a regression which causes
> dsl_dataset_hold_obj() to fail if the dataset is zapified but does not have
> large blocks.
>
> The proposed patch changes the code to use similar construct that
> DS_FIELD_BOOKMARK_NAMES used to avoid overwriting 'err'.
>
>
> Diffs
> -----
>
> usr/src/uts/common/fs/zfs/dsl_dataset.c
> 5baf5c3c0a11db1deb546fa3b365f6faa1bfd4ca
>
> Diff: https://reviews.csiden.org/r/143/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Xin LI
>
>
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
