----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/154/#review449 -----------------------------------------------------------
Ship it! Thanks for the prompt fix! usr/src/uts/common/fs/zfs/sa.c <https://reviews.csiden.org/r/154/#comment375> This seems needless, given that every time we allocate, we also clear this. But that's also true of lots of other fields (e.g. sa_spill), so this isn't any more confusing than what's been there for years. ZFS's use of kmem constructor/destructors seems questionable at best. - Matthew Ahrens On Jan. 27, 2015, 12:01 a.m., Justin Gibbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/154/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 12:01 a.m.) > > > Review request for OpenZFS Developer Mailing List and Rich Lowe. > > > Repository: illumos-gate > > > Description > ------- > > 5562 ZFS sa_handle's violate kmem invariants, debug kernels panic on boot > > uts/common/fs/zfs/sa.c: > In sa_cache_destructor(), remove unnecessary reset of > dbu_evict_func to NULL. > > In sa_handle_get_from_db(), reset dbu_evict_func to NULL > when the sa handle is allocated. > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/sa.c 2e3156c00a4de4304929ef9d578e4e7dbb9f5326 > > Diff: https://reviews.csiden.org/r/154/diff/ > > > Testing > ------- > > ztest via zloop on illumos > > > Thanks, > > Justin Gibbs > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
