----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/152/#review459 -----------------------------------------------------------
Ship it! usr/src/cmd/mdb/common/modules/zfs/zfs.c <https://reviews.csiden.org/r/152/#comment376> It would be more in keeping with the style here to remove dd_phys and use a separate local variable for it. Also will make it easier to eventually convert to the newer, cleaner style of using mdb_ctf_vread() -- see space_cb() for an example. - Matthew Ahrens On Jan. 27, 2015, 3:38 a.m., Justin Gibbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/152/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 3:38 a.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5527 > https://www.illumos.org/projects/illumos-gate//issues/5527 > > > Repository: illumos-gate > > > Description > ------- > > 5527 ::spa_space fails with mdb: couldn't find member dd_phys of type struct > zfs`dsl_dir' > > > Diffs > ----- > > usr/src/cmd/mdb/common/modules/zfs/zfs.c > 225cf3dee18e110149ce6c7180fa50a3928893f9 > > Diff: https://reviews.csiden.org/r/152/diff/ > > > Testing > ------- > > % mdb /dev/ksyms /dev/kmem > Loading modules: [ unix genunix specfs mac cpu.generic uppc apix scsi_vhci > zfs mpt sd ip hook neti sockfs arp usba stmf stmf_sbd fctl lofs random idm > sppp ptm nfs cpc fcip ufs logindmux ] > > ::walk spa | ::spa_space > dd_space_towrite = 0M 0M 0M 0M > dd_phys.dd_used_bytes = 41582M > dd_phys.dd_compressed_bytes = 41166M > dd_phys.dd_uncompressed_bytes = 41166M > ms_allocmap = 0M 0M 0M 0M > ms_freemap = 0M 0M 0M 0M > ms_tree = 964M > last synced avail = 9528M > current syncing avail = 9528M > > > Thanks, > > Justin Gibbs > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
