----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/141/#review522 -----------------------------------------------------------
usr/src/lib/libzfs/common/libzfs_sendrecv.c <https://reviews.csiden.org/r/141/#comment401> As @dweeezil correctly noted this simple solution breaks several usecases. First, zfs recv -F is broken because to implement it the receiving side needs to know about all snpashots that exist on the sending side. Another bug is that the properties are not included into a full stream produced with zfs send -p pool/ds@snap. Most likely the original performance issue better be fixed at the receiving end. - Andriy Gapon On Dec. 2, 2014, 2:11 p.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/141/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 2:11 p.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5380 > https://www.illumos.org/projects/illumos-gate//issues/5380 > > > Repository: illumos-gate > > > Description > ------- > > ... as opposed to sending properties of all snapshots of the relevant > filesystem. The previous behavior results in properties being set on > all snapshots on the receiving side, which is quite slow. > > Behavior of zfs send -R is not changed. > > Note that send_iterate_fs() now has to iterate snapshots in their > creation order. > > > Diffs > ----- > > usr/src/lib/libzfs/common/libzfs_sendrecv.c > c4944438aa2cdcb751ae04a73be52ce9d7b2cef4 > > Diff: https://reviews.csiden.org/r/141/diff/ > > > Testing > ------- > > Only FreeBSD and ZoL. None for illumos. > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
