On 04.04.2015 21:36, Matthew Ahrens wrote: > On Sat, Apr 4, 2015 at 11:18 AM, Alexander Motin <[email protected] > PS: FreeBSD code style does not recommend inline definition of > variables, that you used several times in your patch. > > No C99 in FreeBSD? I didn't realize that illumos was the only operating > system that's updated its language in the past 15 years :-P Personally, > I find that reducing variable scope increases readability as well as > helps avoid bugs.
I haven't told it is not supported. But not everything that is allowed by the language is allowed by style(9). :) Though about reducing scope I personally agree. -- Alexander Motin _______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
