> On April 6, 2015, 3:26 p.m., Steven Hartland wrote: > > usr/src/lib/libzfs/common/libzfs_util.c, line 1517 > > <https://reviews.csiden.org/r/170/diff/2/?file=14448#file14448line1517> > > > > Style: trailing brace.
I already pushed this (as indicated by the review being marked "closed - committed"). But we are actually working on adding a check for this to cstyle, and fixing all the instances of this style issue. - Matthew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/170/#review616 ----------------------------------------------------------- On March 28, 2015, 4:35 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/170/ > ----------------------------------------------------------- > > (Updated March 28, 2015, 4:35 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5692 > https://www.illumos.org/projects/illumos-gate//issues/5692 > > > Repository: illumos-gate > > > Description > ------- > > 5692 expose the number of hole blocks in a file > Reviewed by: Adam Leventhal <[email protected]\> > Reviewed by: Matthew Ahrens <[email protected]\> > > Original author: Max Grossman > > > Diffs > ----- > > usr/src/uts/common/sys/filio.h cbd98af97eb1a0b1abdb6fab7937cabda15c8765 > usr/src/uts/common/fs/zfs/sys/dmu.h > 6e49ae3d09260c33339e17c868976f5f94b1f50e > usr/src/uts/common/fs/zfs/zfs_vnops.c > 5060412afd9b3e3bd2572fa71397426d12bc3cb3 > usr/src/uts/common/fs/zfs/dmu.c 6704df044604547974473b692640a889fa6ce530 > usr/src/lib/libzfs/common/mapfile-vers > 65f266996e168c55d600e26895a12e0ab4cad460 > usr/src/lib/libzfs/common/libzfs_util.c > 414d74ee20660a067cf224b91677c09658a05854 > usr/src/lib/libzfs/common/libzfs.h 9aa5ba59056455d7ecc510189546a1349d65eaa5 > > Diff: https://reviews.csiden.org/r/170/diff/ > > > Testing > ------- > > zfs test suite > ztest > wrote a program to query this, tested with files w/various number and > position of holes in them. > > http://jenkins/job/zfs-precommit/1911/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
