> On April 8, 2015, 1:27 p.m., Bayard Bell wrote: > > usr/src/cmd/zstreamdump/zstreamdump.c, line 114 > > <https://reviews.csiden.org/r/182/diff/1/?file=14441#file14441line114> > > > > Are there style guidelines on preferring to declare at beginning of > > blocks? I've seen code that doesn't, but I find this slower to scan > > Matthew Ahrens wrote: > not as far as I know. I prefer declaring "on demand" since that reduces > variable scope, makes it clear that it's initialized, and typicall results in > less lines of code.
Sold. > On April 8, 2015, 1:27 p.m., Bayard Bell wrote: > > usr/src/uts/common/fs/zfs/dmu_send.c, line 1440 > > <https://reviews.csiden.org/r/182/diff/1/?file=14443#file14443line1440> > > > > Since we pass data as ra->buf in our only caller, do we need the > > parameter? > > Matthew Ahrens wrote: > No, we don't. If you don't mind indulging me a bit here, I'd prefer to > leave this (and the similar functions) as is, becuase I have a bunch more > changes coming to this function, and in the end this won't be a unneeded > parameter. It will make my life a little easier to merge in the coming > changes (for resumable send/receive) if I don't change this too much. Let me > know if that's OK and if not, I'll go ahead and remove the parameter. Sold. - Bayard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/182/#review632 ----------------------------------------------------------- On April 8, 2015, 6:36 p.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/182/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 6:36 p.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 5746 > https://www.illumos.org/projects/illumos-gate//issues/5746 > > > Repository: illumos-gate > > > Description > ------- > > 5746 more checksumming in zfs send > Reviewed by: George Wilson <[email protected]\> > Reviewed by: Christopher Siden <[email protected]\> > > Original author: Matthew Ahrens > > Currently the DRR_END record in zfs send contains the only checksum for a > send stream. In the current world this is a problem because you could get to > the end of a many hour send only to find out a bit error occurred somewhere > in the stream and threw off the checksum. Once resumable send/recv is > integrated, this will be a bigger problem because when a send is interrupted > we lose the checksumming information. > > The solution is to checksum every record so we can detect checksum errors > quickly and know exactly how much of our stream was properly checksummed when > the send is interrupted. There is already unused space in all records except > DRR_BEGIN where a checksum could fit and keep the stream backwards > compatible. Also since a running checksum is already being calculated this > should have minimal impact on performance. > > > Diffs > ----- > > usr/src/uts/common/fs/zfs/sys/zio_checksum.h > 0956c04ab1b43877fcc327d6c9e17d76ac8dbb7d > usr/src/uts/common/fs/zfs/sys/zfs_ioctl.h > 62f6ff997d16350ecc07a4f4a9012192d5de8afb > usr/src/uts/common/fs/zfs/sys/spa.h > d5a8e7f2fd78f49ed7ecb79c2f50cc1e8f13c188 > usr/src/uts/common/fs/zfs/dmu_send.c > 59c6385826da515a0a9b86cecc531c95a84ec408 > usr/src/lib/libzfs/common/libzfs_sendrecv.c > 9a34fb32ea6f2e97283240d5eeb566014d877e99 > usr/src/cmd/zstreamdump/zstreamdump.c > d99d8014f049def80fafae01a7408b199d6c0794 > > Diff: https://reviews.csiden.org/r/182/diff/ > > > Testing > ------- > > zfs test suite > ztest > manual testing > > http://jenkins/job/zfs-precommit/1912/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
