On Mon, Apr 13, 2015 at 10:46 AM, Matthew Ahrens <[email protected]> wrote:
> > > On Mon, Apr 13, 2015 at 10:40 AM, Andriy Gapon <[email protected]> wrote: > >> >> Matt, >> >> is it plausible that dsl_dir_hold(pool, "different-pool/fs", ...) could >> ever be successful? >> > > No, I don't think so. > To elaborate -- besides verifying that, an assertion would also make it clear to the reader that we know they are in the same pool. > --matt > > >> >> >> On 13/04/2015 20:37, Matthew Ahrens wrote: >> >> Could you turn the checks in dmu_objset_clone_check() into assertions >> (plus maybe a comment saying where it is checked), rather than just >> removing them? >> >> --matt >> >> On Mon, Apr 13, 2015 at 4:27 AM, Alexander <[email protected]> >> wrote: >> >>> On 10 Apr 2015 at 19:30:50, Matthew Ahrens ([email protected]) wrote: >>> >>> Ship It! >>> >>> Thanks, especially for using the test suite! >>> >>> --matt >>> >>> On Fri, Apr 10, 2015 at 12:57 AM, Alexander < >>> [email protected]> wrote: >>> >>>> http://cr.illumos.org/~webrev/alhazred/5610/ >>>> >>>> Tested with zfs test suite. >>>> >>>> -- >>>> Alexander >>>> >>>> >>> >>> >>> Thanks to Andriy for suggestion, >>> I’ve updated webrev in place and re-tested. >>> >>> -- >>> Alexander >>> >> >> >> >> -- >> Andriy Gapon >> >> >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
