Arne,
Just a few small comments on the latest review. Please include me as a
reviewer and since my comments are small I'm fine with moving forward.
dmu_objset.c:
line# 1635 (nit)
if (*dcp->dc_error != 0)
line#1666 (nit)
if (dcp->dc_tq != NULL)
line# 1793
- given that you found performance improvements by multiplying the leaf
count by 4 it might be a good idea to make this a tunable.
line# 1796 (nit)
if (tq == NULL)
Thanks,
George
On 5/5/15 8:09 AM, Arne Jansen wrote:
On 05/01/2015 03:53 PM, Arne Jansen wrote:
So how do we continue? Can we ping some FreeBSD folks?
Or just mark the patch as potentially dangerous in the
commit message?
I can of course build the refcnt/cv mechanism, should
we choose this path.
As no one stepped up to tell me to implement the refcnt, I chose the
easier path and put up a big warning sign in both the commit message
and the code.
Attached is the revised patch and the diff to the previous one. I also
updated the webrev at
http://cr.illumos.org/~webrev/sensille/5269_zpool_import_slow/
Dan, George: Thanks for the additional reviews! Is it ok to list you
as reviewers?
-Arne
-------------------------------------------
illumos-zfs
Archives: https://www.listbox.com/member/archive/182191/=now
RSS Feed: https://www.listbox.com/member/archive/rss/182191/22008002-303f2ff4
Modify Your Subscription:
https://www.listbox.com/member/?member_id=22008002&id_secret=22008002-f948b352
Powered by Listbox: http://www.listbox.com
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
