Seems like it will work.  Added a comment to that review:

type!=VOLUME and prop_valid_for_type(CANMOUNT) seem like they are
essentially checking the same thing (is this a filesystem).  It would be
better to make that check once.  e.g.:

if (prop_valid_for_type(CANMOUNT)) {
  if (prop_get_init(CANMOUNT) == ON)) {
    zfs_mount()
  }
}

On Mon, May 25, 2015 at 11:06 AM, Andriy Gapon <[email protected]>
wrote:

>
> ZoL has the following change:
>
> https://github.com/FransUrbo/zfs/commit/dd0e0e69f5b1c83bf2895ac00a0b83af77473175
> https://github.com/zfsonlinux/zfs/issues/2241
>
> I think that that change is correct, because creating a clone does not
> imply a
> wish to mount it.
> What do you think?
>
> --
> Andriy Gapon
> _______________________________________________
> developer mailing list
> [email protected]
> http://lists.open-zfs.org/mailman/listinfo/developer
>
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer

Reply via email to