----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/228/#review741 -----------------------------------------------------------
Ship it! Ship It! - Matthew Ahrens On June 7, 2015, 8:27 a.m., Andriy Gapon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/228/ > ----------------------------------------------------------- > > (Updated June 7, 2015, 8:27 a.m.) > > > Review request for OpenZFS Developer Mailing List. > > > Bugs: 5984 > https://www.illumos.org/projects/illumos-gate//issues/5984 > > > Repository: illumos-gate > > > Description > ------- > > The change is already implemeted in ZoL. > > My main rationale for doing things differently from what was done in ZoL was > to avoid too deep nesting and the resulting line wrapping ugliness. > Additionally, introduction of `should_auto_mount()` should reduce code > duplication `zfs_do_create()` and `zfs_do_clone()`. > Lastly, this change adds diagnostic messages for mounting / sharing failures > in `zfs_do_clone()` similar to those in `zfs_do_create()`. > > > Diffs > ----- > > usr/src/cmd/zfs/zfs_main.c ff04e3a1c6e32918aa6a93aa184942f5511e3bec > > Diff: https://reviews.csiden.org/r/228/diff/ > > > Testing > ------- > > `zfs clone -o canmount=noauto` on FreeBSD. > > > Thanks, > > Andriy Gapon > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
