----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/248/#review814 -----------------------------------------------------------
Ship it! Looks good. (This reminds me that the FreeBSD compatibility code could probably be improved to give more meaningful output when allocation fails instead of a simple abort). - Xin LI On Oct. 6, 2015, 9:34 a.m., Matthew Ahrens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.csiden.org/r/248/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 9:34 a.m.) > > > Review request for OpenZFS Developer Mailing List and Christopher Siden. > > > Bugs: 6290 > https://www.illumos.org/issues/6290 > > > Repository: illumos-gate > > > Description > ------- > > 6290 zdb -h overflows stack > Reviewed by: Prakash Surya <[email protected]> > Reviewed by: George Wilson <[email protected]> > Reviewed by: Brian Donohue <[email protected]> > > Original author: Matthew Ahrens > > > Diffs > ----- > > usr/src/cmd/zdb/zdb.c 6bed2ff2f98a66b1d7b8f98dc294203371c3ed87 > > Diff: https://reviews.csiden.org/r/248/diff/ > > > Testing > ------- > > http://jenkins.delphix.com/job/zfs-precommit/3137/ > > > Thanks, > > Matthew Ahrens > >
_______________________________________________ developer mailing list [email protected] http://lists.open-zfs.org/mailman/listinfo/developer
