Reviewed by: Matthew Ahrens <mahr...@delphix.com> Reviewed by: Alex Reece <a...@delphix.com>
Our style guidelines require that the opening brace of a function definition be on the line after the header, but the cstyle script doesn't check it. Additionally, if a function has a very long header, it is split onto to two lines. These continuation lines are supposed to be indented by four spaces, not a tab. However, cstyle does not verify that this is the case. This change updates the regular expressions to correctly detect these cases. You can view, comment on, or merge this pull request online at: https://github.com/openzfs/openzfs/pull/40 -- Commit Summary -- * 6459 cstyle doesn't detect opening braces on the same line as function header -- File Changes -- M usr/src/cmd/zoneadmd/zcons.c (4) M usr/src/common/net/wanboot/p12aux.h (3) M usr/src/tools/scripts/cstyle.pl (41) -- Patch Links -- https://github.com/openzfs/openzfs/pull/40.patch https://github.com/openzfs/openzfs/pull/40.diff --- Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/40
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
