libzfs_sendrecv.c: 2718-2719, this comment is inaccurate, you set all props every time.
Several of the other large comments you're adding seem wrong, please re-check them. extract_delay_props(), rather than "dontbother", you could see if the nvlist is empty and if so destroy it. zfs_ioctl.c:4296, can you elaborate on what this has to do with errors? zfs_ioctl.c:4302, I think you mean "... AFTER we have merged the delayprops into props", but I don't understand why that is relevant. On Thu, Dec 3, 2015 at 1:05 PM, Dan McDonald <dan...@omniti.com> wrote: > Ping! This should cover Matt's concerns in libzfs. ZFS-Tests came back > as expected. > > Thanks, > Dan > > > On Dec 2, 2015, at 2:18 PM, Dan McDonald <dan...@omniti.com> wrote: > > > > > >> On Dec 2, 2015, at 10:15 AM, Dan McDonald <dan...@omniti.com> wrote: > >> > >> The change I have *INSIDE* zfs_receive_one() can be discarded (around > lines 2929-2960) and replaced with suppression of errors for > "refreservation" around lines 3276 or so for the non-finalsnap snapshots. > Does that make sense to you? I will code it up in the interim. > > > > First off, I meant to say "refquota" not "refreservation". > > > > Second off, I'm running zfs-test on a new set of changes which I hope > address your concerns in libzfs, Matt. Here are the relevant webrevs: > > > > The original pre-review webrev: > > > > http://kebe.com/~danmcd/webrevs/4986-orig/ > > > > The new, improved overall webrev: > > > > http://kebe.com/~danmcd/webrevs/4986/ > > > > And the incremental diffs between the original and the overall: > > > > http://kebe.com/~danmcd/webrevs/4986-reviewonly/ > > > > Hopefully zfs-test will bear out I've broken nothing else. That'll take > an hour, however, and I've an appointment in an hour, so my latency will be > a bit high until later this afternoon. > > > > Dan > > > > > > ------------------------------------------- > illumos-zfs > Archives: https://www.listbox.com/member/archive/182191/=now > RSS Feed: > https://www.listbox.com/member/archive/rss/182191/27179292-bb9021e0 > Modify Your Subscription: > https://www.listbox.com/member/?member_id=27179292&id_secret=27179292-acf9db97 > Powered by Listbox: http://www.listbox.com >
_______________________________________________ developer mailing list developer@open-zfs.org http://lists.open-zfs.org/mailman/listinfo/developer
