> @@ -5862,11 +5880,11 @@ share_mount_one(zfs_handle_t *zhp, int op, int flags,
> char *protocol,
> shared_nfs = zfs_is_shared_nfs(zhp, NULL);
> shared_smb = zfs_is_shared_smb(zhp, NULL);
>
> - if (shared_nfs && shared_smb ||
> - (shared_nfs && strcmp(shareopts, "on") == 0 &&
> - strcmp(smbshareopts, "off") == 0) ||
> - (shared_smb && strcmp(smbshareopts, "on") == 0 &&
> - strcmp(shareopts, "off") == 0)) {
> + if ((shared_nfs && shared_smb) ||
> + ((shared_nfs && strcmp(shareopts, "on") == 0 &&
> + strcmp(smbshareopts, "off") == 0)) ||
> + ((shared_smb && strcmp(smbshareopts, "on") == 0 &&
> + strcmp(shareopts, "off") == 0))) {
no need for ((double parens))
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/56/files#r49884198
_______________________________________________
developer mailing list
[email protected]
http://lists.open-zfs.org/mailman/listinfo/developer
