@ahrens Yes, I've merged it to OpenZFS on OS X, and it does prevent creation of
a dataset with dedup=sha512,verify, etc. unless the corresponding feature is
enabled. However, I just retested, and noticed that the machine still panics
after mount and writing some data with this stack:
```
Mon Jan 25 16:52:23 2016
panic(cpu 0 caller 0xffffff7fade6e1ee): "VERIFY3(" "feature_get_refcount(spa,
feature, &refcount)" " " "!=" " " "45" ") " "failed (" "45" " " "!=" " " "45"
")\n"@zfeature.c:395
Backtrace (CPU 0), Frame : Return Address
0xffffff820421bbd0 : 0xffffff802b61d6d6 mach_kernel : _panic + 0xc6
0xffffff820421bc40 : 0xffffff7fade6e1ee net.lundman.zfs : _feature_do_action +
0x56
0xffffff820421bc80 : 0xffffff7fade18892 net.lundman.zfs : _dmu_object_zapify +
0xc9
0xffffff820421bcb0 : 0xffffff7fade29ed1 net.lundman.zfs :
_dsl_dataset_activate_feature + 0x8a
0xffffff820421bd10 : 0xffffff7fade2b59f net.lundman.zfs : _dsl_dataset_sync +
0x251
0xffffff820421bd50 : 0xffffff7fade372fa net.lundman.zfs : _dsl_pool_sync + 0x13c
0xffffff820421bdd0 : 0xffffff7fade53512 net.lundman.zfs : _spa_sync + 0x3b1
0xffffff820421bed0 : 0xffffff7fade5b85e net.lundman.zfs : _txg_sync_thread +
0x454
0xffffff820421bfb0 : 0xffffff802b6b34b7 mach_kernel : _call_continuation + 0x17
Kernel Extensions in backtrace:
net.lundman.zfs(1.5)[AC464F66-CE5A-3042-B704-089B1AB887FA]@0xffffff7fade06000->0xffffff7fae044fff
dependency:
com.apple.iokit.IOStorageFamily(1.8)[A3CC4E44-8E10-3D9A-BA8E-95743E79D125]@0xffffff7fabb79000
dependency:
net.lundman.spl(1.5.0)[218BEB87-05BF-3684-BE1A-74B6A51DDB29]@0xffffff7faddb8000
```
So clearly it's not fully correct yet.
---
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/51#issuecomment-174752323_______________________________________________
developer mailing list
developer@open-zfs.org
http://lists.open-zfs.org/mailman/listinfo/developer
