If -T doesn't work now at all, how would making the patch conditional on using -T be unsafe?
It's an inherently unsafe operation to begin with. Thanks, Josh Paetzel > On Apr 22, 2016, at 5:58 PM, ilove zfs <ilove...@icloud.com> wrote: > > No. As is said in the issue containing the patch, that would be quite unsafe. > At minimum it would require a -F or two or three. > >> On Apr 22, 2016, at 03:56 PM, Josh Paetzel <jpaet...@fastmail.net> wrote: >> >> I just tested it. >> >> >> >> root@10:/home/jpaetzel # zpool create test md0 >> root@10:/home/jpaetzel # touch /test/hello >> root@10:/home/jpaetzel # zpool export test >> root@10:/home/jpaetzel # zdb -vuuue test >> >> >> >> >> Uberblock: >> magic = 0000000000bab10c >> version = 5000 >> txg = 10 >> >> >> .... >> >> >> >> root@10:/home/jpaetzel # zpool import -T 6 test >> root@10:/home/jpaetzel # ls /test >> hello >> root@10:/home/jpaetzel # zpool export test >> root@10:/home/jpaetzel # zpool import -T 5 test >> root@10:/home/jpaetzel # ls /test >> root@10:/home/jpaetzel # >> >> So the real question is would it be ok to make the change conditional on the >> zpool import -T flag. >> >> >> >> >>> On Fri, Apr 22, 2016, at 04:12 PM, ilove zfs wrote: >>> FWIW, that patch never worked for me. >>> >>>> On Apr 22, 2016, at 02:01 PM, Josh Paetzel <jpaet...@fastmail.net> wrote: >>>> >>>> Alright, well that helped me. >>>> >>>> I'll test that patch now, then see if I can make it conditional on the >>>> -T flag to import. >>>> >>>>> On Fri, Apr 22, 2016, at 01:53 PM, Turbo Fredriksson wrote: >>>>> On Apr 22, 2016, at 6:03 PM, Turbo Fredriksson wrote: >>>>> >>>>> > This is (was?) broken on ZoL as well. Haven't tested it in a year >>>>> > or so, but it WAS broken at least… >>>>> >>>>> >>>>> Just found the ZoL ticket, and it seems to be still a problem >>>>> (posted Dec 4, 2013, so it's an OOOOLD issue). >>>>> >>>>> https://github.com/zfsonlinux/zfs/issues/1926 >>>>> -- >>>>> Imagine you're an idiot and then imagine you're in >>>>> the government. Oh, sorry. Now I'm repeating myself >>>>> Mark Twain >>>> >>>> >>>> -- >>>> >>>> Thanks, >>>> >>>> Josh Paetzel >>>> >> >> -- >> >> Thanks, >> >> Josh Paetzel >> >> ------------------------------------------- openzfs-developer Archives: https://www.listbox.com/member/archive/274414/=now RSS Feed: https://www.listbox.com/member/archive/rss/274414/28015062-cce53afa Modify Your Subscription: https://www.listbox.com/member/?member_id=28015062&id_secret=28015062-f966d51c Powered by Listbox: http://www.listbox.com
