Hi, On Fri, Nov 17, 2017 at 10:25:55AM +0100, Oyvind Albrigtsen wrote: > On 17/11/17 09:13 +0100, Kristoffer Grönlund wrote: > > Dejan Muhamedagic <deja...@fastmail.fm> writes: > > > > > Hi, > > > > > > On Tue, Nov 14, 2017 at 03:16:04PM +0100, Oyvind Albrigtsen wrote: > > > > ClusterLabs is happy to announce resource-agents v4.1.0 rc1. > > > > Source code is available at: > > > > https://github.com/ClusterLabs/resource-agents/releases/tag/v4.1.0rc1 > > > > > > > > The most significant enhancements in this release are: > > > > - new resource agents: > > > > - aws-vpc-route53 > > > > - LVM-activate > > > > > > There was a long and, unfortunately, fruitless discussion > > > regarding this new version of LVM RA and whether it can be merged > > > with the existing LVM RA. In spite of no consensus, Kristoffer > > > eventually merged it. There is now a plugin like system in LVM > > > which should make adding new mechanisms such as lvmlockd easy, > > > but the contributors didn't try yet to adjust the new LVM. > > > > Yeah, my apologies for jumping the gun. I hope we can work this out > > before release. :/ > > > > > > > Furthermore, in case we agree that having two LVM versions is the > > > best way forward, such refactoring would also significantly > > > reduce code duplication. > > > > > > Thanks, > > > > > > Dejan > > > > > > P.S. Right now irrelevant, but LVM-activate doesn't seem like a > > > good name. > > > > If nothing else, it's in keeping with the rest of the mess of bad names > > ;) Maybe we should decide on a naming standard? Abbreviations or no > > abbreviations, CamelCase or lowercase, or lower_case? This could be > > enforced through the CI checks, and the Makefile could make sure to > > install aliases to the old names so as not to break existing > > installations. > I think we should keep them as is for current agents, but new agents > should be lowercase with an optional -'s if that clarifies their > usage.
My point was that it is arguably a pleonasm. The "activate" part is superfluous. Sorry for not being clearer. As for bad names, we need to look no further than the LVM RA: in volgrpname the "name" part is just as much necessary. > > Maybe we could even move IPaddr2 to ip or IP, and move the now-outdated > > agents to a legacy provider... Yeah, I hope we don't need to get into that ;-) Cheers, Dejan > > > > Cheers, > > Kristoffer > > > > > > > > > > > > > > > > > > - minio > > > > - NodeUtilization > > > > - oraasm > > > > - ovsmonitor > > > > - rkt > > > > - ZFS > > > > > > > > - bugfixes and enhancements: > > > > - aws*: fixes and improvements > > > > - CTDB: fixes for newer versions > > > > - CTDB: fix for --logfile being replaced with --logging > > > > - DB2: fix HADR support for DB2 V98+ > > > > - docker: add docker-native healthcheck > > > > - galera: fix for MariaDB 10.1.21+ > > > > - mysql: set correct master score after maintenance mode > > > > - ocf-shellfuncs: improve locking (ocf_take_lock()) > > > > - pgsql: add support for PostgreSQL 10 > > > > - pgsql: allow dynamic membership > > > > - rabbitmq-cluster: fix to work on Pacemaker remote nodes > > > > > > > > The full list of changes for resource-agents is available at: > > > > https://github.com/ClusterLabs/resource-agents/blob/v4.1.0rc1/ChangeLog > > > > > > > > Everyone is encouraged to download and test the new release candidate. > > > > We do many regression tests and simulations, but we can't cover all > > > > possible use cases, so your feedback is important and appreciated. > > > > > > > > Many thanks to all the contributors to this release. > > > > > > > > > > > > Best, > > > > The resource-agents maintainers > > > > > > > > _______________________________________________ > > > > Developers mailing list > > > > Developers@clusterlabs.org > > > > http://lists.clusterlabs.org/mailman/listinfo/developers > > > > > > _______________________________________________ > > > Developers mailing list > > > Developers@clusterlabs.org > > > http://lists.clusterlabs.org/mailman/listinfo/developers > > > > > > > -- > > // Kristoffer Grönlund > > // kgronl...@suse.com > > > > _______________________________________________ > > Developers mailing list > > Developers@clusterlabs.org > > http://lists.clusterlabs.org/mailman/listinfo/developers _______________________________________________ Developers mailing list Developers@clusterlabs.org http://lists.clusterlabs.org/mailman/listinfo/developers
