Hi, Nikita,
On Aug 31, Nikita Malyavin wrote:
> revision-id: 23b15d24eb3 (mariadb-11.0.1-227-g23b15d24eb3)
> parent(s): cb37c99dd87
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-08-30 13:18:52 +0400
> message:
>
> cleanup: add Field::store_yesno
I agree, it's a good idea to have a helper for storing YES/NO in the
field. But I think Field class itself is a wrong place for it.
YES/NO is exclusively INFORMATION_SCHEMA thing and it feels kind of
wrong to have it in the base class.
I'd do a separate function, like store_yes_no(). Or something.
Also, note that you missed few places where it's needed, like
pos=(uchar*) ((field->flags & NOT_NULL_FLAG) ? "NO" : "YES");
table->field[6]->store((const char*) pos,
strlen((const char*) pos), cs);
or
if (updatable_view)
table->field[5]->store(STRING_WITH_LEN("YES"), cs);
else
table->field[5]->store(STRING_WITH_LEN("NO"), cs);
both in sql_show.cc. There are more.
Regards,
Sergei
VP of MariaDB Server Engineering
and secur...@mariadb.org
_______________________________________________
developers mailing list -- developers@lists.mariadb.org
To unsubscribe send an email to developers-le...@lists.mariadb.org
