Hi, Nikita,
On Sep 29, Nikita Malyavin wrote:
> revision-id: 132c56f1325 (mariadb-11.2.1-8-g132c56f1325)
> parent(s): a71b13433f9
> author: Nikita Malyavin
> committer: Nikita Malyavin
> timestamp: 2023-09-23 11:46:36 +0400
> message:
>
> online alter: extract the source to a separate file
>
> Move all the functions dedicated to online alter to a newly created
> online_alter.cc.
Copyright/GPL header in both new files, please.
Also one comment below.
> With that, make many functions static and simplify the static functions
> naming.
>
> Also, rename binlog_log_row_online_alter -> online_alter_log_row.
>
> diff --git a/sql/log_event.h b/sql/log_event.h
> index 848ad0cead9..35142e034f3 100644
> --- a/sql/log_event.h
> +++ b/sql/log_event.h
> @@ -729,19 +729,6 @@ enum Log_event_type
> };
>
>
> -/*
> - Bit flags for what has been writing to cache. Used to
> - discard logs with table map events but not row events and
> - nothing else important. This is stored by cache.
> -*/
> -
> -enum enum_logged_status
> -{
> - LOGGED_TABLE_MAP= 1,
> - LOGGED_ROW_EVENT= 2,
> - LOGGED_NO_DATA= 4,
> - LOGGED_CRITICAL= 8
> -};
>
> static inline bool LOG_EVENT_IS_QUERY(enum Log_event_type type)
> {
> @@ -979,6 +966,19 @@ typedef struct st_print_event_info
> } PRINT_EVENT_INFO;
> #endif
>
> +/**
> + Bit flags for what has been writing to cache. Used to
> + discard logs with table map events but not row events and
> + nothing else important. This is stored by cache.
> +*/
> +enum enum_logged_status
> +{
> + LOGGED_TABLE_MAP= 1,
> + LOGGED_ROW_EVENT= 2,
> + LOGGED_NO_DATA= 4,
> + LOGGED_CRITICAL= 8
> +};
> +
why did you move it? looks unintentional.
Regards,
Sergei
Chief Architect, MariaDB Server
and secur...@mariadb.org
_______________________________________________
developers mailing list -- developers@lists.mariadb.org
To unsubscribe send an email to developers-le...@lists.mariadb.org
