Hi, Alexander, On Oct 17, Sergei Golubchik wrote: > Hi, Alexander, > > The actual code change (replacing strnncollsp with strnncollsp_nchars) > is ok. > > But I didn't like the functions you've created. > The *_ft_* family is quite confusing, I would not expect to see > fulltext-specific functions my_compare.h. I would expect to see > there functions which are generic and named by what they're doing, not > by where they should be used. > > ha_compare_char_fixed and ha_compare_char_varying are better. Names are > clearer and it's kind of understandable what they do.
I've looked at your patch with renamed functions: ha_compare_ft_text_full -> ha_compare_word ha_compare_ft_text_prefix -> ha_compare_word_prefix ha_compare_ft_text -> ha_compare_word_or_prefix That looked better, more clear. I think this would be ok to push. May be with a comment, like /* the following functions are comparing one word of text - a common operation in the full-text search */ Regards, Sergei Chief Architect, MariaDB Server and secur...@mariadb.org _______________________________________________ developers mailing list -- developers@lists.mariadb.org To unsubscribe send an email to developers-le...@lists.mariadb.org
