Hi, Alexander, On Oct 31, Alexander Barkov wrote: > >> +++ b/mysql-test/suite/compat/oracle/r/vcol_innodb.result > >> @@ -0,0 +1,51 @@ > >> +SET @table_open_cache=@@GLOBAL.table_open_cache; > > > > why do you need to manipulate table_open_cache? > > to trigger a reopen? Just do flush tables, it's explicit, more readable > > and more... controllable. > > I copied this test from the original bug report, to prove that > the exact reported problem is gone.
generally it's a good idea. but in case of pquery found bugs, the "test case" is constructed by randomly reordering existsing lines from other test cases. In that case, I think, it wouldn't hurt to rewrite it into something more robust and meaningful. or, think of it that way - if you don't rewrite it, you don't increase the number of different lines in test cases, so pquery will only test permutations of very same lines over and over :) Regards, Sergei Chief Architect, MariaDB Server and secur...@mariadb.org _______________________________________________ developers mailing list -- developers@lists.mariadb.org To unsubscribe send an email to developers-le...@lists.mariadb.org
