Hi, Yuchen,
On Jan 09, Yuchen Pei wrote:
> Hi Sergei,
>
> Regarding 3be269542f4d18eaee0ad8fbeffa55708557879f, I have one comment
> (see below), otherwise ok to push.
>
> > +extern handlerton *spider_hton_ptr;
> > static int spider_trx_status_var(THD *thd, SHOW_VAR *var, char *buff,
> > ulonglong SPIDER_TRX::*counter)
> > {
...
> > + DBUG_RETURN(0);
>
> If it always returns 0, how about we change the signature of this
> function to return void?
Sure, will do.
I've split the change in two commits - one is pure refactoring, the
other is bug fix, and changing the function to void didn't quite fit
into either one. But I'll put it with the fix now, no problem.
Regards,
Sergei
Chief Architect, MariaDB Server
and secur...@mariadb.org
_______________________________________________
developers mailing list -- developers@lists.mariadb.org
To unsubscribe send an email to developers-le...@lists.mariadb.org
