Hi, Alice,

Summary: all good!
Details below:

First, about %B vs %M. The old behavior was inconsistent, we used %B for
standalone names in some locales and for formatting in others.

We cannot make it consistent without breaking anything, something
has to be broken.

Either it'll be ru_RU or it'll be be_BY, cs_CZ, eu_ES, fi_FI, hr_HR,
lt_LT, pl_PL, ru_UA, sk_SK, uk_UA, el_GR. Let's go for a smaller number
of broken locales. This is what your commit is doing, so it's all good,
let's do that.

Regards,
Sergei
Chief Architect, MariaDB Server
and [email protected]

On Feb 10, Alice Sherepa wrote:
> revision-id: 4b41702e758 (mariadb-12.1.1-161-g4b41702e758)
> parent(s): e352b11a3c2
> author: Alice Sherepa
> committer: Alice Sherepa
> timestamp: 2026-02-09 16:06:55 +0100
> message:
> 
> MDEV-38520 Add formatting month's name
> 
> Months names were taken from 
> https://unicode.org/cldr/charts/48/summary/root.html,
> which has two different categories for full month names: "Months - wide - 
> Formatting"
> and "Months - wide - Standalone".
> Formatting is normaly used when the month is a part of a date (e.g., "12 
> January 2026").
> In many languages (like Slavic or Baltic), the month's ending changes in this 
> context.
> Standalone is used when the month name appears alone.
> %B prints "formatting" months names, %M - "standalone" names

Good description

> @@ -1581,57 +1656,46 @@ MY_LOCALE my_locale_ru_RU
...
>  MY_LOCALE my_locale_ru_UA
>  (
>    44,
>    "ru_UA"_Lex_ident_locale,
>    "Russian - Ukraine",
>    FALSE,
> -  &my_locale_typelib_month_names_ru_UA,
> -  &my_locale_typelib_ab_month_names_ru_UA,
> -  &my_locale_typelib_day_names_ru_UA,
> -  &my_locale_typelib_ab_day_names_ru_UA,
> +  &my_locale_typelib_month_names_ru_RU,
> +  &my_locale_typelib_month_names_ru_RU_formatting,
> +  &my_locale_typelib_ab_month_names_ru_RU,
> +  &my_locale_typelib_day_names_ru_RU,
> +  &my_locale_typelib_ab_day_names_ru_RU,
>    8,
>    11,
> -  ',',        /* decimal point ru_UA */
> -  '.',        /* thousands_sep ru_UA */
> -  "\x03\x03", /* grouping      ru_UA */
> +  ',',        /* decimal point ru_RU */
> +  ' ',        /* thousands_sep ru_RU */
> +  "\x03\x03", /* grouping      ru_RU */
>    &global_errmsgs[ru_RU]
>  );

You've changed thousands_sep from a decimal point to a space.
This appears to be correct, matches https://unicode.org data, thank you.

/Sergei
_______________________________________________
developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to