Andre van Toly wrote:Update of /var/cvs/applications/taglib/src/org/mmbase/bridge/jsp/taglib In directory james.mmbase.org:/tmp/cvs-serv6866
Modified Files: ImageTag.java Log Message: No need for this method here. ImageTag extends FieldTag.
So now I still don't get it. ImageTag overrides FieldTag and its' doStartTag method, in which originally handleEditTag was called.
Now, it is not called in image-tag even though it extends FieldTag. Would that not mean that images render uneditable?
Yes, it confused me to the point upon which i decided to remove the method call from ImageTag. And then of course images only represented by <mm:image> became 'invisible' for the EditTag. They render uneditable. Quite stupid and more so because we're all commenting on it on this list :-)
This is what happened, but i still don't understand it fully (the sources are in speeltuin/andre/edittag):
I made the method handleEditTag() in FieldTag protected. Then i noticed that the EditTag lost 'view' of images only represented by <mm:image> in the testtemplates. Upon which i wrote the method call in ImageTag as 'super.handleEditTag()'.
This is the version i checked in in cvs, because the handleEditTag method was already present in FieldTag and it would help people installing the sources i put in speeltuin. I received comments about the addition of super in ImageTag and i removed the whole method call from ImageTag and checked it in in cvs. Then i started experimenting today:
1. I made the method in FieldTag public and i just wrote the call handleEditTag() in ImageTag. In the example templates it worked again.
2. Then i made the method handleEditTag() protected again. And i wrote 'this.handleEditTag()'. EditTag still 'saw' <mm:image> tags (i thought that the declaration 'this' had no meaning, only to make sourcecode more readable by explicitly stating that you are referring to the base class, but in this case it seems to be different?).
3. But when i don not use either 'this' or 'super' the <mm:image> tag is not 'seen' by the EditTag in the template.
Is this is a bug? Or am i doing something wrong?
I still feel that the method should be protected, so i think i will put 'super.handleEditTag()' back in ImageTag. Or shall i make the method public?
---Andr� -- Andr� van Toly http://www.toly.nl mobile +31(0)627233562 ------------------------------------------------------------------>><<-- _______________________________________________ Developers mailing list [email protected] http://lists.mmbase.org/mailman/listinfo/developers
