> - return number1.doubleValue() == number2.doubleValue();
> + return Double.doubleToLongBits(number1.doubleValue()) == Double.doubleToLongBits(number2.doubleValue());
Is there a specific reason to change this? I.e. is double comparion in java unreliable?
> TypeRel.java > // make sure only MMObjectNode's are added > public boolean add(Object object) { > - return super.add((MMObjectNode) object); > + return super.add(object); > } > > // make sure only MMObjectNode's are added > public boolean add(Object object) { > - return super.add((MMObjectNode) object); > + return super.add(object); > }
The casting here is explicit to ensure that 'object' is an MMObjectNode. Should probably be set back? Not sure if it the test is really needed.
> RemoteGenerator.java:
- private static Vector getSubClasses(XMLClass xmlClass) {
+ static Vector getSubClasses(XMLClass xmlClass) {
- private static Vector getSuperClasses(XMLClass xmlClass) {
+ static Vector getSuperClasses(XMLClass xmlClass) {
Why were these methods made package?
-- Pierre van Rooden Mediapark, C 107 tel. +31 (0)35 6772815 "Anything worth doing is worth overdoing."
_______________________________________________ Developers mailing list [email protected] http://lists.mmbase.org/mailman/listinfo/developers
